On 11/17/2014 03:19 PM, Roger Quadros wrote: > On 11/17/2014 02:31 PM, Roger Quadros wrote: >> On 11/17/2014 02:12 PM, Marc Kleine-Budde wrote: >>> On 11/17/2014 01:09 PM, Roger Quadros wrote: >>>> AM4372 SoC has 2 DCAN modules. Add compatible id and >>>> raminit driver data for it. The driver data is same as AM3352 >>>> but this gives us flexibility to add AM4372 specific quirks >>>> if required later. >>> >>> Strictly speaking we don't need the hunk in >>> "drivers/net/can/c_can/c_can_platform.c" yet, iff the AM4372 dts(i) has >>> this compatible: >>> >>> "ti,am4372-d_can", "ti,am3352-d_can" >> >> I tried with that, but checkpatch still gives this warning >> WARNING: DT compatible string "ti,am4372-d_can" appears un-documented -- check ./Documentation/devicetree/bindings/ >> >> I guess we can just live with it. Please ignore this patch in that case. > > Did you meant that we still need to add it in the binding documentation? > It is not usable by itself so won't it be a problem to exist in documentation? I'll take patch 9 as is, since checkpatch is a bit more picky now :) Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachment:
signature.asc
Description: OpenPGP digital signature
