On 11/07/2014 05:22 PM, Mark Brown wrote:
On Fri, Oct 10, 2014 at 05:06:28PM +0300, Tero Kristo wrote:- dev->platform_data = &twl_gpio_auxdata; + if (!strcmp("twl4030-gpio", dev_name(dev))) + dev->platform_data = &twl_gpio_auxdata; + else + dev->platform_data = omap_twl_match_regulator(dev);Looking at this idiom here I'd expect that we'd be adding another string comparison here?
We are actually doing an of_match_node call within the twl_match_regulator. However, we had a short offline discussion with Tony, and this whole function should be fixed to check node compatibility instead of dev_name. I will be posting a new version that does this once I have time to look at it.
What do you think of patch #2 though? Thats more interesting for the regulator driver purposes and if you NAK that one, the floor goes under this whole approach.
-Tero -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
