On Wednesday 05 November 2014 11:40 PM, Dave Gerlach wrote: > Sekhar, > On 11/05/2014 10:04 AM, Sekhar Nori wrote: >> On Wednesday 05 November 2014 09:27 PM, Dave Gerlach wrote: >>> On 08/26/2014 03:52 AM, Daniel Mack wrote: >>>> This patch makes the edma driver resume correctly after suspend. Tested >>>> on an AM33xx platform with cyclic audio streams and omap_hsmmc. >>>> >>>> All information can be reconstructed by already known runtime >>>> information. >>>> >>>> As we now use some functions that were previously only used from __init >>>> context, annotations had to be dropped. >>>> >>>> [nm@xxxxxx: added error handling for runtime + suspend_late/early_resume] >>>> Signed-off-by: Nishanth Menon <nm@xxxxxx> >>>> Signed-off-by: Daniel Mack <zonque@xxxxxxxxx> >>>> Tested-by: Joel Fernandes <joelf@xxxxxx> >>>> Acked-by: Joel Fernandes <joelf@xxxxxx> >>>> --- >>>> Changes from v8: >>>> >>>> * Drop the edma_suspend hook altogether. Even though back then >>>> when I wrote the code I was sure disabling the interrupts >>>> during suspend is necessary, tests now show it in fact isn't. >>>> My test setup still works if that code is omitted. >>>> * Use SET_LATE_SYSTEM_SLEEP_PM_OPS in the dev_pm_ops >>>> declaration. >>>> >>>> Thanks to Sekhar for pointing out the above. >>>> >>>> arch/arm/common/edma.c | 60 ++++++++++++++++++++++++++++++++++++++++++++++++-- >>>> 1 file changed, 58 insertions(+), 2 deletions(-) >>> >>> Doesn't seem to be any comments here, any chance this can be picked up? This >>> patch always seems to get missed but will be needed for suspend/resume on both >>> AM335x and AM437x. >> >> Dave, do you have a branch against mainline with suspend working on any >> of these SoCs using which I can test this patch? > > Yes, here is WIP of next version with all required patches + this one. > https://github.com/dgerlach/linux-pm/tree/pm-ds0-v3.18-rc3-WIP > > For suspend to work you need to select: > > CONFIG_WKUP_M3_IPC=y > CONFIG_WKUP_M3_RPROC=y I get this: arch/arm/mach-omap2/pm33xx.c:28:31: fatal error: linux/wkup_m3_ipc.h: No such file or directory #include <linux/wkup_m3_ipc.h> ^ compilation terminated. make[1]: *** [arch/arm/mach-omap2/pm33xx.o] Error 1 Forgot to commit wkup_m3_ipc.h? Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
