In commit 7d5929c1f343 ("mtd: nand: omap: Revert to using software ECC by default"), we switched back to using 1-bit SW ECC scheme by default. However commit b491da7233d5 ("mtd: nand: omap: clean-up ecc layout for BCH ecc schemes") didn't take into account the 1-bit SW scheme (i.e. OMAP_ECC_HAM1_CODE_SW) when checking for small page devices because it was already got rid of one commit earlier. Consider OMAP_ECC_HAM1_CODE_SW while deciding if we can proceed with small page devices or not. Fixes: 7d5929c1f34 ("mtd: nand: omap: Revert to using software ECC by default") Cc: <stable@xxxxxxxxxxxxxxx> [3.17+] Reported-by: Tony Lindgren <tony@xxxxxxxxxxx> Signed-off-by: Roger Quadros <rogerq@xxxxxx> --- drivers/mtd/nand/omap2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index 3b357e9..758e594 100644 --- a/drivers/mtd/nand/omap2.c +++ b/drivers/mtd/nand/omap2.c @@ -1742,7 +1742,8 @@ static int omap_nand_probe(struct platform_device *pdev) } /* check for small page devices */ - if ((mtd->oobsize < 64) && (pdata->ecc_opt != OMAP_ECC_HAM1_CODE_HW)) { + if ((mtd->oobsize < 64) && (pdata->ecc_opt != OMAP_ECC_HAM1_CODE_HW) && + (pdata->ecc_opt != OMAP_ECC_HAM1_CODE_SW)) { dev_err(&info->pdev->dev, "small page devices are not supported\n"); err = -EINVAL; goto return_error; -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html