* Roger Quadros <rogerq@xxxxxx> [141029 01:51]: > On 10/29/2014 12:23 AM, Tony Lindgren wrote: > > * Roger Quadros <rogerq@xxxxxx> [141021 05:43]: > >> Simplify set_gpmc_timing_reg() and always print error message > >> if the requested timing cannot be achieved due to a too fast > >> GPMC functional clock, irrespective if whether DEBUG is defined > >> or not. This should help us debug timing configuration issues, > >> which were otherwise simply not being displayed in the kernel log. > > > > I think some newer versions of GPMC have a divider in the > > GPMC_CONFIG regs somewhere but we're not currently using it. > > Probably does not affect this patch, just FYI. > > Right, we don't use it. In the future it could be a possibility that the GPMC > driver scales the clock as necessary by using the GPMC_FCLK divider > to accommodate slower devices. But then again, who needs slower devices? ;) I think some devices need such slow timings that we're already hitting the issue with 200MHz L3 on 37xx connected to a SMSC LAN9220 at least. With LAN9221 this is not an issue with faster timings. Anyways, I think the issue is out of the way now with LAN9220 and GPMC_FCLK divider support can be added later on as needed. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
