On 09/30/2014 04:26 PM, Wolfram Sang wrote: > On Tue, Sep 09, 2014 at 05:31:09PM +0300, Roger Quadros wrote: >> Some TI SoCs like DRA7 have a RAMINIT register specification >> different from the other AMxx SoCs and as expected by the >> existing driver. >> >> To add more insanity, this register is shared with other >> IPs like DSS, PCIe and PWM. >> >> Provides a more generic mechanism to specify the RAMINIT >> register location and START/DONE bit position and use the >> syscon/regmap framework to access the register. >> >> Signed-off-by: Roger Quadros <rogerq@xxxxxx> >> --- >> .../devicetree/bindings/net/can/c_can.txt | 7 ++ >> drivers/net/can/c_can/c_can.h | 11 ++- >> drivers/net/can/c_can/c_can_platform.c | 109 +++++++++++++++------ >> 3 files changed, 95 insertions(+), 32 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/can/c_can.txt b/Documentation/devicetree/bindings/net/can/c_can.txt >> index 8f1ae81..e12d1a1 100644 >> --- a/Documentation/devicetree/bindings/net/can/c_can.txt >> +++ b/Documentation/devicetree/bindings/net/can/c_can.txt >> @@ -13,6 +13,13 @@ Optional properties: >> - ti,hwmods : Must be "d_can<n>" or "c_can<n>", n being the >> instance number >> >> +- ti,raminit-syscon : Handle to system control region that contains the >> + RAMINIT register. If specified, the second memory resource >> + in the reg property must index into the RAMINIT >> + register within the syscon region > > There seems to be a simple "syscon" property these days. I had used plain "syscon" in the earlier revisions but was asked to make it a TI specific property since only TI uses this mechanism. > >> +- ti,raminit-start-bit : Bit posistion of START bit in the RAMINIT register >> +- ti,raminit-done-bit : Bit position of DONE bit in the RAMINIT register > > This should not be encoded in DT! This is not describing hardware setup. > The driver should know where the bits are for the syscon phandle, > depending on which SoC it runs... > OK. I'll think of matching the compatible ID with SOC specific data in the driver. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
