On 09/02/2014 10:12 PM, pekon wrote: > On Tuesday 02 September 2014 07:27 PM, Roger Quadros wrote: >> For NAND read & write wait pin monitoring must be kept disabled as the >> wait pin is only used to indicate NAND device ready status and not to >> extend each read/write cycle. >> > I think this description, does not fit in this patch. It fits the description because it gives the reason why wait monitoring is optional. > And is incorrect as explained in previous patch review. It is correct. I've pointed you to the relevant TRM sections where it is said that GPMC read/write monitoring must be disabled for NAND case. cheers, -roger > > >> So don't print a warning if wait pin is specified while read/write >> monitoring is not in the device tree. >> >> Sanity check wait pin number irrespective if read/write monitoring is >> set or not. >> >> Signed-off-by: Roger Quadros <rogerq@xxxxxx> >> --- > But below mentioned checks and clean-up makes sense. So > apart from first 3 lines of commit log .. > > Reviewed-by: Pekon Gupta <pekon@xxxxxxxxxxx> > > > with regards, pekon > > ------------------------ > Powered by BigRock.com > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
