Re: [PATCH] ARM: OMAP2+: fix gpmc_cs_remap: re-allocating chip-select address space based on DT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Roger,

On Fri, Aug 1, 2014 at 4:30 PM, Roger Quadros <rogerq@xxxxxx> wrote:
> On 07/23/2014 09:17 PM, Pekon Gupta wrote:
>> +     /* allocate enough address-space under GPMC chip-select to device */
>> +     if (size > SZ_256M) {
>> +             pr_err("%s: memory device > 256MB not supported\n", __func__);
>> +             return -ENODEV;
>> +     } else if (size > SZ_128M) {
>> +             WARN((size != SZ_256M), "cs=%d: allocating 256MB\n", cs);
>> +             size = SZ_256M;
>> +     } else if (size > SZ_64M) {
>> +             WARN((size != SZ_128M), "cs=%d: allocating 128MB\n", cs);
>> +             size = SZ_128M;
>> +     } else if (size > SZ_32M) {
>> +             WARN((size != SZ_64M), "cs=%d: allocating 64MB\n", cs);
>> +             size = SZ_64M;
>> +     } else if (size > SZ_16M) {
>> +             WARN((size != SZ_32M), "cs=%d: allocating 64MB\n", cs);
>
> Print message should be "allocating 32MB"
>
yes, my bad, copy-paste errors..

[...]

>
> Otherwise it is fine. I can make the changes and resend.
>
> cheers,
> -roger
>
Yes please re-send. Thanks much.


with regards, pekon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux