* Roger Quadros <rogerq@xxxxxx> [140711 03:25]: > On 07/11/2014 12:42 PM, Gupta, Pekon wrote: > > > > Therefore, I suggest you to move following code from NAND driver to > > GPMC driver, nothing other than. And this exported function does not > > need any NAND framework information, except number_of_sectors. > > Well I you have still not pointed out what is the benefit of that approach or what are the problems with the approach I am suggesting. > > I am suggesting that the API just return the ECC/BCH result registers as it is. > You are suggesting that the API do the calculations and return the NAND ready ECC buffer. > > To do the calculations it needs to know about the ECC scheme which is NAND controller specific and this is unnecessary in the GPMC driver. > > Tony, what is your opinion? As long as the GPMC registers are exposed to drivers in a controlled way and we have only one driver using the ECC registers, I don't care. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
