Hi Roger, >From: Quadros, Roger > >Even though the ECC/BCH engine is meant for exclusive use by >the OMAP NAND controller, the ECC/BCH registers belong >to the GPMC controller's register space > >Add omap_gpmc_ecc_configure_enable() and omap_gpmc_ecc_disable() >to manage the ECC engine. OMAP NAND driver must use these APIs >instead of directly accessing the ECC Engine registers. > >Signed-off-by: Roger Quadros <rogerq@xxxxxx> >--- As suggested in http://lists.infradead.org/pipermail/linux-mtd/2014-July/054595.html Please try to move chip->ecc.calculate() implementations like - omap_calculate_ecc_bch() - omap_calculate_ecc() >From NAND driver To GPMC driver, as that should be easy, And solve most of your work (no need to export GPMC registers). - You may rename them appropriately and change the argument list if needed. - And NAND driver can just have some wrapper functions to match the MTD interface arguments. with regards, pekon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
