* Aaro Koskinen <aaro.koskinen@xxxxxxxxx> [090216 08:40]: > Hello, > > ext Jarkko Nikula wrote: >> Jarkko Nikula <jhnikula@xxxxxxxxx> wrote: >>> Tony's version does not fix the issue since obj-$(CONFIG_I2C_OMAP) >>> below still tries to compile arch/arm/plat-omap/i2c.c as a module. >>> >>> -obj-$(CONFIG_I2C_OMAP) += i2c.o >>> + >>> +ifneq ($(CONFIG_I2C_OMAP),) >>> + obj-$(CONFIG_I2C_OMAP) += i2c.o >>> +endif >>> >> And build works if obj-y rule is used instead >> >> -obj-$(CONFIG_I2C_OMAP) += i2c.o >> + >> +ifneq ($(CONFIG_I2C_OMAP),) >> + obj-y += i2c.o >> +endif >> >> Good. Patch can be made to touch only single file and add only three new >> lines. > > Taking example from fs/Makefile (nfsd): > > -obj-$(CONFIG_I2C_OMAP) += i2c.o > +i2c-omap-$(CONFIG_I2C_OMAP) := i2c.o > +obj-y += $(i2c-omap-m) $(i2c-omap-y) > > Also arch/arm/plat-omap/include/mach/common.h should be updated to check > for CONFIG_I2C_OMAP_MODULE. That seems cleaner to me. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
