Re: [PATCH 1/1] Allow I2C_OMAP to compile as a module.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 13 Feb 2009 14:21:00 -0800
Tony Lindgren <tony@xxxxxxxxxxx> wrote:

> > Subject needs a "ARM: OMAP: " prefix, otherwise ok from me.
> > 
> > Acked-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxx>
> 
> Sounds like a fix, except I posted a shorter version of the patch that
> should do the trick (untested). Attached here too for reference.
> 
Tony's version does not fix the issue since obj-$(CONFIG_I2C_OMAP) below
still tries to compile arch/arm/plat-omap/i2c.c as a module.

-obj-$(CONFIG_I2C_OMAP) += i2c.o
+
+ifneq ($(CONFIG_I2C_OMAP),)
+	obj-$(CONFIG_I2C_OMAP)		+= i2c.o
+endif

Problem was that drivers/i2c/busses/i2c-omap.c can be module but
arch/arm/plat-omap/i2c.c cannot since it is for early board
initialization code.

-- 
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux