>From: Guido Martínez [mailto:guido@xxxxxxxxxxxxxxxxxxxx] >>On Tue, Jul 01, 2014 at 07:01:03AM +0000, Gupta, Pekon wrote: >> >http://lists.infradead.org/pipermail/linux-arm-kernel/2014-June/266966.html >> > >> I don't think we need above patch. >> Helper macro "for_each_available_child_of_node" internally takes care >> of skipping nodes with status="disabled". >> >> $KERNEL/include/linux/of.h >> #define for_each_available_child_of_node(parent, child) \ >> for (child = of_get_next_available_child(parent, NULL); child != NULL; \ >> child = of_get_next_available_child(parent, child)) >> >> $KERNEL/drivers/of/base.c @@ of_get_next_available_child(...) { >> ... >> if (!__of_device_is_available(next)) >> continue; >> ... >Yes, that's why I suggest using that macro. It's not currently used >in gpmc.c and my patch changes the 'for_each_child_of_node' to a >'for_each_available_child_of_node'. Or am I missing something? > Oops my bad. I was probably dreaming, I already had your patch in my tree before reviewing the code. So please ignore my previous email. with regards, pekon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
