> >>Add palmas_pmic_driver_data structure.
> >>
> >>Signed-off-by: Keerthy <j-keerthy@xxxxxx>
> >>---
> >> include/linux/mfd/palmas.h | 25 +++++++++++++++++++++++++
> >> 1 file changed, 25 insertions(+)
> >>
> >>diff --git a/include/linux/mfd/palmas.h b/include/linux/mfd/palmas.h
> >>index 8d68452..70f0695 100644
> >>--- a/include/linux/mfd/palmas.h
> >>+++ b/include/linux/mfd/palmas.h
[...]
> >>+struct palmas_pmic_driver_data {
> >>+ int smps_start;
> >>+ int smps_end;
> >>+ int ldo_begin;
> >>+ int ldo_end;
> >>+ int max_reg;
> >>+ struct regs_info *palmas_regs_info;
> >>+ struct of_regulator_match *palmas_matches;
> >>+ struct palmas_sleep_requestor_info *sleep_req_info;
> >>+ int (*smps_register)(struct palmas_pmic *pmic,
> >>+ struct palmas_pmic_driver_data *ddata,
> >>+ struct palmas_pmic_platform_data *pdata,
> >>+ const char *pdev_name,
> >>+ struct regulator_config config);
> >>+ int (*ldo_register)(struct palmas_pmic *pmic,
> >>+ struct palmas_pmic_driver_data *ddata,
> >>+ struct palmas_pmic_platform_data *pdata,
> >>+ const char *pdev_name,
> >>+ struct regulator_config config);
> >Are you sure you need to store all of this stuff?
> >
> >Particularly the match pointer. Do you really re-use it?
>
> Match pointer is used extensively in the palmas_regulator.c.
> This structure is very much used by regulator driver.
On closer inspection, I now see that it's a 'of_regulator_match',
rather than an 'of_match' pointer, which were my initial thoughts. I
think it would have been weird to carry the 'of_match', but the
reality sounds sane.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
