> add driver data and modularize the probe. > > Signed-off-by: Keerthy <j-keerthy@xxxxxx> > --- > drivers/mfd/palmas.c | 42 +-- > drivers/regulator/palmas-regulator.c | 656 ++++++++++++++++++++-------------- > 2 files changed, 395 insertions(+), 303 deletions(-) > > diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c [...] > @@ -370,6 +334,8 @@ int palmas_ext_control_req_config(struct palmas *palmas, > int bit_pos; > int ret; > > + struct palmas_pmic_driver_data *pmic_ddata = palmas->pmic_ddata; > + Nit: I'd prefer the declarations to be grouped together, normally with the struct defines above the ints etc. [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
