Re: [RFC] OMAP DT i2c aliases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On  2.06.2014 19:19, Nishanth Menon wrote:

I think that slipped my check list unfortunately. :( But then, if we
think that it is just n900 that is impacted, then I wonder if we can
override the alias? just wondering..


That https://lkml.org/lkml/2014/6/1/49 patch will allow such override, I tested it on N900 with Fremantle and it works fine. Ofc I had to add

aliases {
	i2c1 = &i2c1;
	i2c2 = &i2c2;
	i2c3 = &i2c3;
};

to omap3-n900.dts (while keeping omap3.dtsi intact) for it to work.

I checked in some Nemo N9/N950 adaptation kernel and it seems those will be broken too(and I bet it is the same in stock Nokia N9/50 kernels):

static void __init rm680_i2c_init(void)
{
	omap3_pmic_get_config(&rm680_twl_data, TWL_COMMON_PDATA_USB,
			      TWL_COMMON_REGULATOR_VDAC |
			      TWL_COMMON_REGULATOR_VPLL2);
	omap_pmic_init(1, 2900, "twl5031", INT_34XX_SYS_NIRQ, &rm680_twl_data);
	omap_register_i2c_bus(2, 400, rm696_peripherals_i2c_board_info_2,
			      ARRAY_SIZE(rm696_peripherals_i2c_board_info_2));
	omap_register_i2c_bus(3, 400, rm696_peripherals_i2c_board_info_3,
			      ARRAY_SIZE(rm696_peripherals_i2c_board_info_3));
}

Again 1,2 and 3 for bus indexes just like on N900.

Anyway, I am fine with the alias override. If the patch makes it to the upstream :)

Regards,
Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux