On 12 May 2014 18:16, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > * Joachim Eastwood <manabian@xxxxxxxxx> [140511 10:28]: >> On 9 May 2014 18:07, Tony Lindgren <tony@xxxxxxxxxxx> wrote: >> > >> > I was thinking that too initially, but then we would have macros that behave >> > in a different way: >> > >> > 1. Calculate the iopad offset from the iopad register area start based on >> > the iopad physical address >> > >> > 2. Calculate the iopad offset from the iopad register area start based on >> > the iopadd offset from the driver base address >> > >> >> One other possibility is to use my original patch in this mail or just >> >> create a OMAP4_IOPAD with offset 0x040 which will on OMAP4 work for >> >> both core and wkup. >> > >> > That also makes the macro behave in a different way depending on the >> > SoC which is not nice. >> >> How about something like this then: >> /* >> * Macros to allow using the offset from the padconf physical address >> * instead of the offset from padconf base. >> */ >> #define OMAP_PADCONF_OFFSET(offset, base_offset) ((offset) - (base_offset)) >> >> #define OMAP4_IOPAD(offset, val) OMAP_PADCONF_OFFSET((offset), 0x0040) (val) >> #define OMAP5_IOPAD(offset, val) OMAP_PADCONF_OFFSET((offset), 0x0040) (val) >> >> The OMAP4/5 TRMs list address offsets from the padconf physical >> address (which is not driver base address) and not absolute physical >> address for padconf registers like some other OMAP TRMs. So create a >> new macro to avoid confusion between different OMAP parts. >> >> I can cook up a patch if you like the idea above. > > Sure sounds good to me. The offset is different for at least omap3 > instances, so those should use OMAP3_*_IOPAD macros. So you are okey with just OMAP4_IOPAD for both core and wkup pads? If so I'll send out a patch with the stuff above for OMAP4 and 5. Then I'll update my patch set, rebase it on your omap-for-v3.16/dt branch and post it the list. regards Joachim Eastwood -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
