On 04/22/2014 01:47 PM, Nishanth Menon wrote: > On Tue, Apr 22, 2014 at 1:31 PM, Joel Fernandes <joelf@xxxxxx> wrote: >> On my DRA7 system, when the kernel is built in THUMB mode, the secondary CPU > Did you mean THUMB2? omap2plus_defconfig works today with > CONFIG_ARM_THUMB enabled.. ARM_THUMB is for user binaries though, not kernel. But yeah I should reword the commit message to use Thumb-2. I'll do that. > >> (Cortex A15) fails to come up causing SMP boot on second CPU to timeout. This >> seems to be because the CPU is in ARM mode once the ROM hands over control to >> the kernel. Switch to THUMB mode if required once the kernel is control of >> secondary CPU. On OMAP4 on the other hand, it appears to be in THUMB mode on >> entry so this is not required and SMP boot works as is. >> >> Cc: Santosh Shilimkar <santosh.shilimkar@xxxxxx> >> Cc: Russell King <linux@xxxxxxxxxxxxxxxx> >> Cc: Nishanth Menon <nm@xxxxxx> >> Cc: Tony Lindgren <tony@xxxxxxxxxxx> >> Signed-off-by: Joel Fernandes <joelf@xxxxxx> >> --- >> arch/arm/mach-omap2/omap-headsmp.S | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/omap-headsmp.S b/arch/arm/mach-omap2/omap-headsmp.S >> index 75e9295..1809dce 100644 >> --- a/arch/arm/mach-omap2/omap-headsmp.S >> +++ b/arch/arm/mach-omap2/omap-headsmp.S >> @@ -1,7 +1,7 @@ >> /* >> * Secondary CPU startup routine source file. >> * >> - * Copyright (C) 2009 Texas Instruments, Inc. >> + * Copyright (C) 2014 Texas Instruments, Inc. > 2009-2014 Sure. > >> * >> * Author: >> * Santosh Shilimkar <santosh.shilimkar@xxxxxx> >> @@ -28,9 +28,13 @@ >> * code. This routine also provides a holding flag into which >> * secondary core is held until we're ready for it to initialise. >> * The primary core will update this flag using a hardware >> -+ * register AuxCoreBoot0. >> + * register AuxCoreBoot0. > > spurious change? > The "+" is spurious, I was trying to correct that. Will update commit message in v2. thanks, -Joel -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
