RE: [PATCH] I2C: OMAP: Include OMAP_I2C_SYSC_REG in save and restore

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> >         omap_i2c_write_reg(dev, OMAP_I2C_IE_REG, dev->iestate);
> > @@ -300,14 +302,15 @@ static int omap_i2c_init(struct omap_i2c
> >                 } else if (dev->rev >= OMAP_I2C_REV_ON_3430) {
> >                         u32 v;
> 
> This local variable is left unused, so you will get a compiler warning.
> 
> > -                       v = SYSC_AUTOIDLE_MASK;
> > -                       v |= SYSC_ENAWAKEUP_MASK;
> > -                       v |= (SYSC_IDLEMODE_SMART <<
> > +                       dev->syscstate = SYSC_AUTOIDLE_MASK;
> > +                       dev->syscstate |= SYSC_ENAWAKEUP_MASK;
> > +                       dev->syscstate |= (SYSC_IDLEMODE_SMART <<
> >                               __ffs(SYSC_SIDLEMODE_MASK));
> > -                       v |= (SYSC_CLOCKACTIVITY_FCLK <<
> > +                       dev->syscstate |= (SYSC_CLOCKACTIVITY_FCLK <<
> >                               __ffs(SYSC_CLOCKACTIVITY_MASK));
> >
> > -                       omap_i2c_write_reg(dev, OMAP_I2C_SYSC_REG, v);

The variable "v", holds the value to be written to OMAP_I2C_SYSC_REG. I compiled the code for omap_3430sdp_defconfig, and received no compiler warning.

-Jagadeesh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux