Hello Russell, On Thu, 29 Jan 2009, Russell King - ARM Linux wrote: > On Wed, Jan 28, 2009 at 12:27:51PM -0700, Paul Walmsley wrote: > > Previously the individual clock recalculation functions handled their > > own rate recalculation. This can be handled in the clk_set_rate(), > > clk_set_parent(), and recalculate_root_clocks() functions in > > plat-omap/clock.c. Removes duplicate code and clarifies the role of the > > recalc functions. > > I must say that this commit looks very much like a combination of > my commits from November: > > [ARM] omap: move clock propagation into core omap clock code > [ARM] omap: remove unnecessary calls to propagate_rate() > [ARM] omap: move propagate_rate() calls into generic omap clock code > > which do basically the same thing a little more efficiently, and an > additional patch from you to call ->recalc after set_rate or > reparenting a clock. > > So I think I can drop everything from this apart from the additional > recalc calls, and the removal of those omap2_dpllcore_recalc() calls. > > Please confirm my suspicions. I haven't looked closely at your above three patches for this, but plan to do so later today. Regarding provenance, the patches that I sent you were developed independently, for clock notifier support. Ultimately, I have no personal attachment as to whose patches for this go in, if all technical aspects are equal. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
