On Thu, 29 Jan 2009, Russell King - ARM Linux wrote: > On Wed, Jan 28, 2009 at 12:18:48PM -0700, Paul Walmsley wrote: > > From: Tony Lindgren <tony@xxxxxxxxxxx> > > > > This fixes booting, and is a step toward fixing things properly: > > > > - Make enable_reg u32 instead of u16 > > No, you're passing this to __raw_read/write, so it needs to be > void __iomem *, not u32. If there's another patch doing that it > needs to be combined with this one. The miniscule details of > fixes upon fixes aren't interesting for submission purposes, and > just adds extra unnecessary review load for upstream people. > > Ditto for anything else which is passed to __raw_read/write*. Will build a revised patch for this and pass it to Tony for a boot test, then repost. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
