On Wed 2014-02-26 08:24:44, Jenny Tc wrote: > On Fri, Feb 21, 2014 at 03:45:29PM +0100, Pavel Machek wrote: > > On Thu 2014-02-20 10:46:55, Jenny Tc wrote: > > > On Tue, Feb 04, 2014 at 12:36:40PM +0100, Pavel Machek wrote: > > > > > --- a/drivers/power/Kconfig > > > > > +++ b/drivers/power/Kconfig > > > > > @@ -22,6 +22,19 @@ config POWER_SUPPLY_CHARGER > > > > > drivers to keep the charging logic outside and the charger driver > > > > > just need to abstract the charger hardware. > > > > > > > > > > +config POWER_SUPPLY_CHARGING_ALGO_PSE > > > > > + bool "PSE compliant charging algorithm" > > > > > + help > > > > > + Say Y here to select Product Safety Engineering (PSE) compliant > > > > > + charging algorithm. As per PSE standard the battery characteristics > > > > > + and thereby the charging rates can vary on different temperature > > > > > + zones. This config will enable PSE compliant charging algorithm with > > > > > + maintenance charging support. At runtime the algorithm will be > > > > > + selected by the psy charger driver based on the type of the battery > > > > > + charging profile. > > > > > > > > Information where to expect PSE compliant chargers would be nice. > > > > > > This algorithm can be used with non PSE compliant chargers also. This is a SW > > > based charging algorithm. > > > > Ok, but you need to explain for the users when it might be good idea > > to select this option... > > > > Or maybe this should not be user configurable and drivers should just > > select it? > > The idea is to allow pluggable charging algorithms. Currently we have only one > charging algorithm proposed, but can have other charging algorithms (like pulse > charging, rule based charging etc.). Based on the platform need, the algorithms > can be selected. So this should be a user configurable option. I can add more > explanation on when to select this option. Yes please. Because with current description, user has no chance. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html