On Thu, Feb 20, 2014 at 10:24:21PM -0600, Joel Fernandes wrote: > diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c > index dc95efc..ae0ccae 100644 > --- a/arch/arm/common/edma.c > +++ b/arch/arm/common/edma.c > @@ -1469,11 +1470,14 @@ static int edma_xbar_event_map(struct device *dev, > if (!xbar_chans) > return -ENOMEM; > > - ret = of_address_to_resource(node, 1, &res); > - if (ret) > + pdev = to_platform_device(dev); > + res = platform_get_resource_byname(pdev, > + IORESOURCE_MEM, > + "edma_xbar"); > + if (!res) > return -EIO; > > - xbar = devm_ioremap(dev, res.start, resource_size(&res)); > + xbar = devm_ioremap(dev, res->start, resource_size(res)); > if (!xbar) > return -ENOMEM; Irrespective of what Mark said, this should be upgraded to use devm_ioremap_resource() which does all the checking necessary (and claims the resource.) That can be done irrespective of this change. -- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit". -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
