On Wed, Feb 19, 2014 at 2:22 PM, Paul Walmsley <paul@xxxxxxxxx> wrote: > On Wed, 19 Feb 2014, Vaibhav Bedia wrote: > >> On Wed, Feb 19, 2014 at 1:25 PM, Paul Walmsley <paul@xxxxxxxxx> wrote: >> > >> > Just FYI. Queued for v3.15 unless someone complains. >> > >> >> No complains but i wanted to point out that with some additional >> changes it's possible >> to consolidate AM335x (and AM437x) very nicely with the rest of OMAP4+ >> PRM/CM code. >> >> I had posted a series (which had a similar patch) a while back [1] but >> that got never >> got any feedback :/ > > Yeah, to be honest I don't like the consolidation approach. The reason > why is because the hardware seems to be quite different underneath, so the > risk of breaking another chip is high. > >> If one looks hard enough AM335x/AM437x/TI81xx are not that different >> from OMAP4+ :) > > Hmm, it's my understanding that the hardware implementations are quite > different between the Wireless and the Catalog parts. Certainly the > Wireless engineers didn't have any knowledge at all of what Catalog folks > were doing, and many implementation assumptions that held true across > several Wireless parts did not hold up at all when extended to Catalog > parts. > After spending a lot of time looking at the code and PRCM specs for the different chips i had come to the conclusion that in reality the Catalog parts had the same hardware minus intelligence ;) The control bits are the same with just the AUTO modes in the PWRDM, CLKDM, CLKCTRL never being supported. The series touched less than 100 lines of OMAP4 code and from what i can see it was just making it generic in a couple of places. Most of the changes were just getting rid of AM335x specific pieces. FWIW i had even suspend/resume also working on AM335x on top of that series so a breakage, if any, should be simple to fix up. On the contrary i found it easier to fix any breakage on AM335x due to common code. But i'll leave the final decision to you :) Regards, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
