On Mon, 10 Feb 2014, Kevin Hilman wrote: > > The issue started I think with the following patch getting merged: > > ehci-platform: Add support for clks and phy passed through devicetree > > some version of http://www.spinics.net/lists/linux-usb/msg101061.html > > introduced { .compatible = "usb-ehci", }, > > This is what I was getting at: an understanding of what caused the > failue in the first place. > > > Now, in the build we have two drivers which dts claims compatibility > > with, but only 1 driver actually works (drivers/usb/host/ehci-omap.c) > > for the platform. Thinking that way, in fact, the current > > compatibility even matches drivers/usb/host/ehci-ppc-of.c which > > obviously wont work either. > > Right, so I agree that it makes sense to remove a compatible string > where there is no compatability, but a couple other things should happen > here. > > 1) changelog should describe why this compatible string is in the omap > dtsi files in first place. > > 2) investigation into the patch that introduced this change to double > check it's not introducing other breakage as well. Oddly enough, it was Roger who introduced this incorrect compatibility string in commit f17c89948dcd6 (ARM: dts: OMAP4: Add HS USB Host IP nodes). There is no explanation in the commit log of why the string is there. We better remove it from all the files where it doesn't belong. Of course, this won't help existing hardware. It will still be necessary to change the compatibility string used for the generic platform drivers. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
