[OMAPZOOM][PATCH] OMAP3ISP: Fix lsc_initialized flag setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>From 551a60b7f66bdf314702062214345464679e6481 Mon Sep 17 00:00:00 2001
From: Sergio Aguirre <saaguirre@xxxxxx>
Date: Fri, 16 Jan 2009 16:17:07 -0600
Subject: [PATCH] OMAP3ISP: Fix lsc_initialized flag setting

This patch fixes an incorrect clearing of the lsc_initialized
flag, so when loading an equal or lower size LSC table from abstraction
layer, the flag doesn't get cleared anymore.

The leakage comes because on ispccdc_cleanup(), the unmmap was
conditioned when lsc_initialized was set to 1.

Based on Fix by Margarita Olaya on Internal TI tree.

Signed-off-by: Margarita Olaya <magi.olaya@xxxxxx>
Signed-off-by: Sergio Aguirre <saaguirre@xxxxxx>
---
 drivers/media/video/isp/ispccdc.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/media/video/isp/ispccdc.c b/drivers/media/video/isp/ispccdc.c
index 75a4a06..fab4f72 100644
--- a/drivers/media/video/isp/ispccdc.c
+++ b/drivers/media/video/isp/ispccdc.c
@@ -270,11 +270,12 @@ int omap34xx_isp_ccdc_config(void *userspace_add)
 						ispccdc_lsc_config)))
 					goto copy_from_user_err;
 				down(&ispccdc_mutex);
-				lsc_initialized = 0;
 				if (lsc_config.size <= old_size)
 					size_mismatch = 0;
-				else
+				else {
 					size_mismatch = 1;
+					lsc_initialized = 0;
+				}
 				up(&ispccdc_mutex);
 				ispccdc_config_lsc(&lsc_config);
 			}
-- 
1.5.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux