On Tuesday 13 January 2009 09:34:16 ext Hans Verkuil wrote: > second entry rather than the third. There are more devices that can > choose between color and B&W, but this is the first device I know of > that can do sepia. Having B&W as the second entry makes it easier for Actually OMAP3 ISP can do pretty much arbitrary matrix operations on colors, so normal, B&W, and sepia and very special cases. :) > > > > +#ifdef TERM_RESISTOR > > > > > > What is this define? It doesn't seem to be documented. > > > > This define is to enable/disable an OMAP34xx internal resistor for > > CSIb (CCP2) camera port. > > > > A comment along its declaration should be enough? > > Yes. But shouldn't this be a module option, perhaps? Up to you, I'm just > wondering. Rather it should be somehow specified in board file. When one connects camera module to the OMAP3, he can choose to either use OMAP3 internal resistor (and specify its strength), or solder an external resistor on the CCP2 bus. Machine specific board file should specify how the camera module is connected to the camera port, thus it should describe what kind of OMAP3 internal resistor is required. - Tuukka -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
