On Wed, Jan 07, 2009 at 07:50:21PM +0200, Tony Lindgren wrote: > * Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> [090107 18:18]: > > On Wed, Jan 07, 2009 at 01:17:45PM +0200, Tony Lindgren wrote: > > > - set_irq_type(OMAP_GPIO_IRQ(SW_ENTER_GPIO16), IRQ_TYPE_EDGE_RISING); > > > - if (request_irq(OMAP_GPIO_IRQ(SW_ENTER_GPIO16), &apollon_sw_interrupt, > > > + set_irq_type(gpio_to_irq(SW_ENTER_GPIO16), IRQ_TYPE_EDGE_RISING); > > > + if (request_irq(gpio_to_irq(SW_ENTER_GPIO16), &apollon_sw_interrupt, > > > > NAK. I wonder how the f*** this got anywhere near the mainline kernel. > > No no no no no. set_irq_type + request_irq is utter crap and should be > > rejected whenever its seen. There's absolutely no need for it - > > request_irq is sufficient. Get rid of this set_irq_type usage from > > everywhere please. > > Blind search and replace? :) I've removed the GPIO key code as there's > already a patch to do that cleaner with gpio_keys. Revised patch is fine. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
