> -----Original Message----- > From: Richard Purdie [mailto:rpurdie@xxxxxxxxx] > Sent: Wednesday, January 07, 2009 8:37 PM > To: Premi, Sanjeev > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] Backlight driver for omap3evm > > On Wed, 2009-01-07 at 20:25 +0530, Sanjeev Premi wrote: > > This patch implements the backlight driver for OMAP3EVM. > > The mechanism for backlight control is reused from the existing > > controls in lcd_omap3evm.c. > > Please see the reply to the email you sent me offlist. What > happens when you run this driver on something that isn't an omap3evm? The driver implementation depends upon CONFIG_MACH_OMAP3EVM. > > The problem is that this bit: > > omap_backlight_dev = platform_device_alloc(OMAPBL_DEVNAME, -1); > Ah, this bit can be moved to board specific file in "mach-omap2" directory. > should be done in the platform code for the board, not in the > general driver. If you do that, you should be able to reuse > most of the generic-bl device code. I tried so, but wasn't able to get the Kconfig dependencies right to get 'generic-bl' into my build. Hence, removed the code that I believed to be generic (since yesterday's mail) and created the patch. Will give another try. > > Regards, > > Richard > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
