-----Original Message----- From: Mark Brown [mailto:broonie@xxxxxxxxxxxxx] Sent: Tuesday, January 06, 2009 3:30 PM To: Pillai, Manikandan Cc: linux-omap@xxxxxxxxxxxxxxx Subject: Re: [PATCH 1/2] TPS6235x based Power regulator support added On Tue, Jan 06, 2009 at 10:11:42AM +0530, Pillai, Manikandan wrote: > Except the comment from Mark, I have so far not received any comments on > these patch set of 2 for TPS6235x support. As attached below, there are problems > with implementing Mark's comments. Suggestions are welcome. The consumer data should be passed into the driver as platform-specific data and passed straight through to the regulator API. The struct devices that are used in the consumer array should be those for the consumer devices so the regulator driver is not in a position to know what the appropriate device to use is. [Pillai, Manikandan] The consumer data is being passed through the struct tps_6235x_i2c_board_info in board specific file board-omap3evm.c. But for struct regulator_consumer_supply tps62352_core_consumers the Member dev needs to be inited. .dev is not available at this point of time. If dev is not initialized, the regulator_register() is failing. Both tps62352_core_consumers and tps62352_mpu_consumers and their I2C addresses are board specific - if references to them are included in your driver then other boards will not be able to use your driver. [Pillai, Manikandan] Agreed - this makes the driver unusable for other boards. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
