> > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > > * Aguirre Rodriguez, Sergio Alberto <saaguirre@xxxxxx> [081215 09:02]: > > > > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > > > > * Aguirre Rodriguez, Sergio Alberto <saaguirre@xxxxxx> [081211 > 12:44]: > > > > > + case V4L2_POWER_OFF: > > > > > + /* Power Down Sequence */ > > > > > +#ifdef CONFIG_TWL4030_CORE > > > > > + twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER, > > > > > + VAUX_DEV_GRP_NONE, TWL4030_VAUX2_DEV_GRP); > > > > > +#else > > > > > +#error "no power companion board defined!" > > > > > +#endif > > > > > > > > These checks look unecessary. How about just handle it with Kconfig? > > > > > > > [Aguirre, Sergio] But how? Don't you think that if I do that, I'll > > tighten the sensor driver to this board only? > > > > > > > See what we've done with arch/arm/mach-omap2/mmc-twl4030.c for example > > in linux-omap tree. > [Aguirre, Sergio] Hmm, I'm a bit confused here. Can you help me clarify? > > I see that you're adding mmc-twl4030 compilation in Makefile for every > board that supports it and adding twl4030_mmc_init() call to the > corresponding board init function. I see that you're also conditioning > almost all code inside mmc-twl4030.c with "if > defined(CONFIG_TWL4030_CORE)" compiler check. > > Can you help me see how is this different to what I'm doing? > [Aguirre, Sergio] Or maybe you meant to condition all sensors support with "#if defined(CONFIG_TWL4030_CORE)" check, without returning error on else case? > > The twl and mmc patches are on their way to the mainline > > kernel too hopfully this merge window. > > > > Regards, > > > > Tony > > > -- > video4linux-list mailing list > Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe > https://www.redhat.com/mailman/listinfo/video4linux-list -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
