On Thu, Dec 11, 2008 at 8:49 AM, Paul Walmsley <paul@xxxxxxxxxxx> wrote: > Hi Grazvydas, Steve, > > On Thu, 11 Dec 2008, Grazvydas Ignotas wrote: > >> > Can you please post whatever patches you need to apply to make it work >> > occasionally so others can also look at the issue? >> >> For pandora, making infinite while loops finite doesn't help much, >> kernel crashes later on. Steve had this too: >> http://marc.info/?l=linux-omap&m=122378604027303&w=2 >> >> I did bisect and found that commit >> 8b1f0bd44fe490ec631230c8c040753a2bda8caa is causing the hang for me. >> Reverting this makes EHCI work again on pandora. >> http://marc.info/?l=linux-omap&m=122453174024860&w=2 > > Would one of you be willing to run with this patch and send back any debug > output relating to dpll5_ck ? (Unfortunately, I don't have access to any > boards with EHCI hardware, so cannot try it myself) > > This will help determine what fix should be applied Here you go. Note that no infinite loop! ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver clock: dpll5_ck: clk->rate = 0, hdwr rate = 120000000, parent rate = 13000000 ehci-omap ehci-omap.0: OMAP-EHCI Host Controller ehci-omap ehci-omap.0: new USB bus registered, assigned bus number 2 ehci-omap ehci-omap.0: irq 77, io mem 0x48064800 usb 1-1: new high speed USB device using musb_hdrc and address 2 ehci-omap ehci-omap.0: USB 2.0 started, EHCI 1.00 usb usb2: configuration #1 chosen from 1 choice hub 2-0:1.0: USB hub found hub 2-0:1.0: 3 ports detected usb usb2: New USB device found, idVendor=1d6b, idProduct=0002 usb usb2: New USB device strings: Mfr=3, Product=2, SerialNumber=1 usb usb2: Product: OMAP-EHCI Host Controller usb usb2: Manufacturer: Linux 2.6.28-rc7-omap1 ehci_hcd usb usb2: SerialNumber: ehci-omap.0 Steve > - Paul > > > > Add debugging in omap3_noncore_dpll_enable() - for testing only. > > --- > arch/arm/mach-omap2/clock34xx.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/clock34xx.c b/arch/arm/mach-omap2/clock34xx.c > index 2c655be..3b80667 100644 > --- a/arch/arm/mach-omap2/clock34xx.c > +++ b/arch/arm/mach-omap2/clock34xx.c > @@ -275,6 +275,10 @@ static int omap3_noncore_dpll_enable(struct clk *clk) > if (!dd) > return -EINVAL; > > + pr_info("clock: %s: clk->rate = %ld, hdwr rate = %d, parent " > + "rate = %ld\n", clk->name, clk->rate, > + omap2_get_dpll_rate(clk), dd->bypass_clk->rate); > + > if (clk->rate == dd->bypass_clk->rate) > r = _omap3_noncore_dpll_bypass(clk); > else > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html