Hi,
>Hi Tero
>
>one comment on this patch ...
>
>On Thu, 11 Dec 2008, Tero Kristo wrote:
>
>> Previously only 1 and 2 was supported. This is needed for
>DVFS VDD2 control.
>
>> diff --git a/arch/arm/mach-omap2/sram34xx.S
>> b/arch/arm/mach-omap2/sram34xx.S index 16eb4ef..832cd76 100644
>> --- a/arch/arm/mach-omap2/sram34xx.S
>> +++ b/arch/arm/mach-omap2/sram34xx.S
>> @@ -70,6 +70,7 @@
>> * r5 = number of MPU cycles to wait for SDRC to stabilize after
>> * reprogramming the SDRC when switching to a slower MPU speed
>> * r6 = new SDRC_MR_0 register value
>> + * r7 = increasing SDRC rate? (1 = yes, 0 = no)
>> *
>> */
>> ENTRY(omap3_sram_configure_core_dpll)
>> @@ -78,8 +79,8 @@ ENTRY(omap3_sram_configure_core_dpll)
>> ldr r5, [sp, #56] @ load extra args from the stack
>> ldr r6, [sp, #60] @ load extra args from the stack
>
>you will also need a
>
> ldr r7, [sp, #64] @ load extra args from the stack
>
>here
Woops. Resending in a bit.
Funny though that this patch does not seem to affect system stability
too
much at initial testing, it did not cause any crash when I tried this
out.
Might cause problems in longer run / stress testing.
>> dsb @ flush buffered writes
>to interconnect
>> - cmp r3, #0x2 @ if increasing SDRC clk rate,
>> - blne configure_sdrc @ program the SDRC regs
>early (for RFR)
>> + cmp r7, #1 @ if increasing SDRC clk rate,
>> + bleq configure_sdrc @ program the SDRC regs
>early (for RFR)
>> cmp r4, #SDRC_UNLOCK_DLL @ set the intended DLL state
>> bleq unlock_dll
>> blne lock_dll
>> @@ -89,7 +90,7 @@ ENTRY(omap3_sram_configure_core_dpll)
>> cmp r4, #SDRC_UNLOCK_DLL @ wait for DLL status to change
>> bleq wait_dll_unlock
>> blne wait_dll_lock
>> - cmp r3, #0x1 @ if increasing SDRC clk rate,
>> + cmp r7, #1 @ if increasing SDRC clk rate,
>> beq return_to_sdram @ return to SDRAM code,
>otherwise,
>> bl configure_sdrc @ reprogram SDRC regs now
>> mov r12, r5
>> diff --git a/arch/arm/plat-omap/include/mach/sram.h
>> b/arch/arm/plat-omap/include/mach/sram.h
>> index d07da3b..ad0a600 100644
>> --- a/arch/arm/plat-omap/include/mach/sram.h
>> +++ b/arch/arm/plat-omap/include/mach/sram.h
>> @@ -24,7 +24,8 @@ extern u32 omap2_set_prcm(u32 dpll_ctrl_val, u32
>> sdrc_rfr_val, int bypass); extern u32
>omap3_configure_core_dpll(u32 sdrc_rfr_ctrl,
>> u32 sdrc_actim_ctrla,
>> u32 sdrc_actim_ctrlb, u32 m2,
>> - u32 unlock_dll, u32 f, u32
>sdrc_mr);
>> + u32 unlock_dll, u32 f, u32 sdrc_mr,
>> + u32 inc);
>> extern void omap3_sram_restore_context(void);
>>
>> /* Do not use these */
>> @@ -62,7 +63,9 @@ extern unsigned long
>> omap243x_sram_reprogram_sdrc_sz;
>>
>> extern u32 omap3_sram_configure_core_dpll(u32 sdrc_rfr_ctrl,
>> u32 sdrc_actim_ctrla,
>> - u32 sdrc_actim_ctrlb, u32 m2);
>> + u32 sdrc_actim_ctrlb, u32 m2,
>> + u32 unlock_dll, u32
>f, u32 sdrc_mr,
>> + u32 inc);
>> extern unsigned long omap3_sram_configure_core_dpll_sz;
>>
>> #ifdef CONFIG_PM
>> diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
>> index 68a1f69..9f6232f 100644
>> --- a/arch/arm/plat-omap/sram.c
>> +++ b/arch/arm/plat-omap/sram.c
>> @@ -372,10 +372,10 @@ static u32
>(*_omap3_sram_configure_core_dpll)(u32 sdrc_rfr_ctrl,
>> u32 sdrc_actim_ctrla,
>> u32 sdrc_actim_ctrlb,
>> u32 m2, u32 unlock_dll,
>> - u32 f, u32 sdrc_mr);
>> + u32 f, u32
>sdrc_mr, u32 inc);
>> u32 omap3_configure_core_dpll(u32 sdrc_rfr_ctrl, u32
>sdrc_actim_ctrla,
>> u32 sdrc_actim_ctrlb, u32 m2, u32
>unlock_dll,
>> - u32 f, u32 sdrc_mr)
>> + u32 f, u32 sdrc_mr, u32 inc)
>> {
>> if (!_omap3_sram_configure_core_dpll)
>> omap_sram_error();
>> @@ -383,7 +383,7 @@ u32 omap3_configure_core_dpll(u32
>sdrc_rfr_ctrl, u32 sdrc_actim_ctrla,
>> return _omap3_sram_configure_core_dpll(sdrc_rfr_ctrl,
>> sdrc_actim_ctrla,
>> sdrc_actim_ctrlb, m2,
>> - unlock_dll, f, sdrc_mr);
>> + unlock_dll, f,
>sdrc_mr, inc);
>> }
>>
>> #ifdef CONFIG_PM
>> --
>> 1.5.4.3
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe
>linux-omap"
>> in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo
>> info at http://vger.kernel.org/majordomo-info.html
>>
>
>
>- Paul
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
