On Wed, 3 Dec 2008 12:35:08 +0530 "Hiremath, Vaibhav" <hvaibhav@xxxxxx> wrote: > I can tell you that for OMAP3 we do have lot of files coming in, and it really brings more confusion if we have OMAP1 and OMAP2 lying outside and OMAP3 code (Display + capture) say under omap/ or omap3/. > > It makes sense to have omap/ directory, and all the versions/devices of OMAP get handled from omap/Kconfig and omap/Makefile. Even if they have single file it would be nice to follow directory layers. > > Hans, Sakari or Mauro can provide their opinion on this, and decide how to handle this. > > I am just providing details, so that it would be easy to take decision - > > OMAP1 - (I have listed names from old O-L tree) > - omap16xxcam.c > - camera_core.c > - camera_hw_if.h > - omap16xxcam.h > - camera_core.h > > OMAP2 - (I have listed names from old O-L tree) > - omap24xxcam.c > - omap24xxcam-dma.c > - omap24xxcam.h > > In future may be display will add here. > > OMAP3 - > Display - (Posted twice with old DSS library) > - omap_vout.c > - omap_voutlib.c > - omap_voutlib.h > - omap_voutdef.h > Camera - (Will come soon) > - omap34xxcam.c > - omap34xxcam.h > ISP - (Will come soon) > - Here definitely we will plenty number of files. I prefer to have a separate directory for omap drivers. This helps to confine Kconfig/Makefile changes internally to the driver sub-dir, avoiding merge conflicts with other drivers. Also, it helps to better organize the files. By listening to Trilok arguments that this would be converted into just two files for each omap version in the long run, Maybe we can just add all thee drivers into /omap. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
