Hi Mark, Looks like I don't need this change. I just am testing my changes without this patch. Did not see the rdev_get_drvdata() ? Regards Mani -----Original Message----- From: Mark Brown [mailto:broonie@xxxxxxxxxxxxx] Sent: Monday, December 08, 2008 3:10 PM To: Pillai, Manikandan Cc: linux-omap@xxxxxxxxxxxxxxx; lrg@xxxxxxxxxxxxxxx Subject: Re: [PATCH 1/1] Relocating struct regulator_dev to include/linux/regulator/driver.h. On Mon, Dec 08, 2008 at 03:06:49PM +0530, Manikandan Pillai wrote: > The struct regulator_dev declaration has been moved from > driver/regulator/core.c to include/linux/regulator/driver.h for > supporting new regulators. > Signed-off-by: Manikandan Pillai <mani.pillai@xxxxxx> Why do you want to do this? I've seen one driver which appeared to be using this only to open code rdev_get_drvdata(). If other details of the contents are required are accessor functions not sufficient? -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html