Hi Soni, Thanks, Vaibhav Hiremath > -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > owner@xxxxxxxxxxxxxxx] On Behalf Of Trilok Soni > Sent: Sunday, December 07, 2008 3:11 PM > To: Hans Verkuil > Cc: v4l; linux-omap@xxxxxxxxxxxxxxx Mailing List; Sakari Ailus > Subject: Re: [PATCH] Add Omnivision OV9640 sensor support. > > Hi Hans, > > On Mon, Dec 1, 2008 at 6:21 PM, Trilok Soni <soni.trilok@xxxxxxxxx> > wrote: > > Hi Hans, > > > >> > >> I reviewed this sensor driver and it's fine except for one thing: > >> setting the default registers from outside the driver. This is a > really > >> bad idea. I2C drivers should be self-contained. I've made the > same > >> comment in the tvp514x driver review which I'm copying below > (with some > >> small edits): > > > > I knew that you are going to comment on that, and I agree on those > > points. I will pull in that register initialization to the driver. > > > > Attached the updated ov9640 sensor patch. > [Hiremath, Vaibhav] I just had quick walk through of code and I think you may want to take look at the review comments received for TVP514x driver (Especially for I2C). > -- > ---Trilok Soni > http://triloksoni.wordpress.com > http://www.linkedin.com/in/triloksoni -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
