Hi David, >From: David Brownell [mailto:david-b@xxxxxxxxxxx] >Sent: Friday, December 05, 2008 3:39 AM >To: Ramirez Luna, Omar >Cc: linux-omap@xxxxxxxxxxxxxxx; Hiroshi DOYU; Gupta, Ramesh; Kanigeri, Hari >Subject: Re: [linux-omap] [PATCH 2/2] DSPBRIDGE: Freeing allocated >resources on rmmod > >On Thursday 04 December 2008, Ramirez Luna, Omar wrote: >> + DSP_STATUS dsp_status = DSP_SOK; >> + HANDLE hDrvObject = NULL; >> + struct PROCESS_CONTEXT *pTmp = NULL; >> + struct PROCESS_CONTEXT *pCtxtclosed = NULL; >> + struct PROCESS_CONTEXT *pCtxttraverse = NULL; > >It WoUlD bE a LoT nIcEr ... > >... if new code didn't introduce new CamelCase usage, >and didn't use Hungarian notation. > >Hungarian notation makes some sense in assembly language, >where it was created to help cope with the lack of typing. >But not in C. Thanks for your comments and time, we are still working towards meeting open source standards and enhancing the code with all the feedback received (RW, RMK, TL, HD, FC and many more people) to get the driver pushed a piece at a time. There are still action items in our list, along with coding style, but we'll keep working to get them done. - omar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
