On Wednesday 03 December 2008 08:05:08 Hiremath, Vaibhav wrote: > Thanks, > Vaibhav Hiremath > > > -----Original Message----- > > From: Trilok Soni [mailto:soni.trilok@xxxxxxxxx] > > Sent: Wednesday, December 03, 2008 12:18 PM > > To: Hiremath, Vaibhav > > Cc: Hans Verkuil; Sakari Ailus; linux-omap@xxxxxxxxxxxxxxx Mailing > > List; video4linux-list@xxxxxxxxxx > > Subject: Re: [PATCH] Add OMAP2 camera driver > > > > Hi Vaibhav, > > > > > [Hiremath, Vaibhav] How about making a separate directory for > > > > OMAP, which will contain OMAP1/2/3 specific drivers? > > > > > > I really don't want omap directory for OMAP1 and OMAP2 atleast. > > Even in my next patches for OMAP1 camera controller I am going to > > remove "omap/" directory existing on linux-omap git history. For > > omap1 it is > > just two files camera_core.c and omap16xxcam.c, so no need of > > directory here. Even going further I am going to merge camera_core > > and > > omap16xxcam into one file, as I don't see code for any other omap1 > > platform like omap15xxcam. > > > > I don't know about OMAP3 ISP code, some one from TI should refresh > > those patches. > > [Hiremath, Vaibhav] I can tell you that for OMAP3 we do have lot of > files coming in, and it really brings more confusion if we have OMAP1 > and OMAP2 lying outside and OMAP3 code (Display + capture) say under > omap/ or omap3/. > > It makes sense to have omap/ directory, and all the versions/devices > of OMAP get handled from omap/Kconfig and omap/Makefile. Even if they > have single file it would be nice to follow directory layers. > > Hans, Sakari or Mauro can provide their opinion on this, and decide > how to handle this. > > I am just providing details, so that it would be easy to take > decision - > > OMAP1 - (I have listed names from old O-L tree) > - omap16xxcam.c > - camera_core.c > - camera_hw_if.h > - omap16xxcam.h > - camera_core.h > > OMAP2 - (I have listed names from old O-L tree) > - omap24xxcam.c > - omap24xxcam-dma.c > - omap24xxcam.h > > In future may be display will add here. > > OMAP3 - > Display - (Posted twice with old DSS library) > - omap_vout.c > - omap_voutlib.c > - omap_voutlib.h > - omap_voutdef.h > Camera - (Will come soon) > - omap34xxcam.c > - omap34xxcam.h > ISP - (Will come soon) > - Here definitely we will plenty number of files. Looking at this I would say that there are enough files to make it sensible to add an omap directory. I would also suggest that some naming convention for the sources is kept: e.g. omap1-. omap2-, omap3- prefixes to clearly show for which omap version a source is. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
