Thanks, Vaibhav Hiremath > -----Original Message----- > From: David Brownell [mailto:david-b@xxxxxxxxxxx] > Sent: Tuesday, December 02, 2008 2:05 PM > To: Hiremath, Vaibhav > Cc: dbrownell@xxxxxxxxxxxxxxxxxxxxx; video4linux-list@xxxxxxxxxx; > davinci-linux-open-source-bounces@xxxxxxxxxxxxxxxxxxxx; linux- > omap@xxxxxxxxxxxxxxx; Jadav, Brijesh R; Shah, Hardik; Hadli, > Manjunath; R, Sivaraj; Karicheri, Muralidharan > Subject: Re: [PATCH 2/2] TVP514x Driver with Review comments fixed > > On Monday 01 December 2008, David Brownell wrote: > > > - Pointer to init_reg_seq, which is pointer to array of > structure > > > for tvp514x_regs. This is little bit ugly, since will > have to > > > export tvp514x_regs structure. > > > > The platform_data should not hold such stuff; it's not board- > specific. > > I'd expect platform_data to hold regulator_init_data as needed to > > instantiate the regulator; and maybe other stuff needed on this > board > > too. Floor and ceiling parameters, maybe, unless they change at > runtime. > > Apologies, I was confusing this driver with another. For a video > codec, the platform_data should say things like which of the dozen > or so input channels are wired up, and how; and how the outputs > are encoded (8 bits, 2x 8 bits, 10 bits, 2x 10 bits, etc). Nothing > to do with regulators or DVFS. > > And the id parameter to probe() is enough to tell whether this is > a '46 device, with extra registers and input channels, or a '47 > that's less capable (but lower power, etc). > > [Hiremath, Vaibhav] To avoid any more confusion, I will post the patch again for review, which will give you clear picture. > > The init sequence wouldn't matter at all for i2c_get_clientdata(), > > since it should only kick in during probe(). > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
