Hi Hans, > > I reviewed this sensor driver and it's fine except for one thing: > setting the default registers from outside the driver. This is a really > bad idea. I2C drivers should be self-contained. I've made the same > comment in the tvp514x driver review which I'm copying below (with some > small edits): I knew that you are going to comment on that, and I agree on those points. I will pull in that register initialization to the driver. > > I noticed that the tcm825x.c driver takes exactly the same wrong > approach, BTW. Yes, because ov9640 was the first sensor driver on OMAP2 ;) -- ---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
