On Friday 28 November 2008, hvaibhav@xxxxxx wrote: > +/* > + * Supported standards - These must be ordered according to enum tvp514x_std > + * order. In this case it'd be easy to remove that restriction... > + * Currently supports two standards only, need to add support for rest of the > + * modes, like SECAM, etc... > + */ > +static struct tvp514x_std_info tvp514x_std_list[] = { > + { [STD_NTSC_MJ] = { > + .width = NTSC_NUM_ACTIVE_PIXELS, > + .height = NTSC_NUM_ACTIVE_LINES, > + .video_std = VIDEO_STD_NTSC_MJ_BIT, > + .standard = { > + .index = 0, > + .id = V4L2_STD_NTSC, > + .name = "NTSC", > + .frameperiod = {1001, 30000}, > + .framelines = 525 > + }, > + }, { [STD_PAL_BDGHIN] = { ... ... for clarity. Though it's more conventional to have the "undefined" value be zero, and thus what kzalloc or static initialization provides, than have NTSC be zero. :) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html