Re: [PATCH 1/3] Adding-support-framework for PR785 board.

Koen Kooi <k.kooi@xxxxxxxxxxxxxxxxxx> · Fri, 28 Nov 2008 12:02:14 +0100

Op 28 nov 2008, om 11:50 heeft Felipe Balbi het volgende geschreven:

On Fri, Nov 28, 2008 at 11:11:29AM +0100, Koen Kooi wrote:
Yes... you should for example:

static struct i2c_board_info omap3evm_i2c_board_info[] __initdata  
= {
... (all devices but tps and twl) ...
};

static struct i2c_board_info pr785_i2c_board_info[] __initdata = {
	{
		I2C_BOARD_INFO("tps62352_core_pwr", 0x4A),
		.flags = I2C_CLIENT_WAKE,
	}, {
		I2C_BOARD_INFO("tps62353_mpu_pwr", 0x48),
		.flags = I2C_CLIENT_WAKE,
	},
};

static struct i2c_board_info twl4030_i2c_board_info[] __initdata = {
	{
		I2C_BOARD_INFO("twl4030", 0x48),
	},
};

Then on init:

...

omap_register_i2c_bus(1, omap3_evm_i2c_board_info,
		ARRAY_SIZE(omap3evm_i2c_board_info);

if (machine_is_pr785())
	i2c_register_board_info(1, pr785_i2c_board_info,
		ARRAY_SIZE(pr785_i2c_board_info));

That's looks like unreachable code to me, since the pr785 is a
daughterboard of the omap3evm machine.

Hmm... that's news to me. But make it runtime check somehow. We can't
accept this kind of ifdefs in the i2c_board_info since it breaks  
multiomap.

And Tony has been pushing for it for quite a while, so let's not make
his life more difficult.

I'm not advocating ifdefs, quite the reverse. I was just pointing out  
that the pr785 is a daughterboard for the evm :) My omap3evm board has  
the twl4030 daughterboard, so I sadly can't test patches for the pr785.

regards,

Koen

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux- 
omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Attachment:
PGP.sig

Description: This is a digitally signed message part