> -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of David > Brownell > Sent: Friday, November 28, 2008 12:33 PM > To: Pillai, Manikandan > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 3/3] musb: Remvoing twl4030 dependency for OMAP3EVM MUSB > > On Thursday 27 November 2008, Manikandan Pillai wrote: > > #if defined(CONFIG_ARCH_OMAP2430) > > omap_cfg_reg(AE5_2430_USB0HS_STP); > > + x = otg_get_transceiver(); > > +#elif defined(CONFIG_MACH_OMAP3EVM) > > + x = kzalloc(sizeof *x, GFP_KERNEL); > > + if (!x) > > + return 0; > > + x->set_host = omap3_evm_otg_set_host; > > + x->set_peripheral = omap3_evm_otg_set_peripheral; > > + x->set_suspend = omap3_evm_otg_set_suspend; > > + otg_set_transceiver(x); > > #endif > > This is obviously wrong. One does set_transceiver(), > the other does get_transceiver() ... For OMAP3EVM we don't need twl4030 support for musb and thus otg_set_transceiver() which was done in twl4030-usb.c, is now done here itself for OMAP3EVM. Whereas for SDP and Beagle twol4030-usb would be enabled and thus otg_set_transceiver() would have been done in twl4030-usb.c file itself. > > It seems that some boards need some kind of basic > OTG transceiver stub. The newish drivers/usb/otg > directory is the place to keep such stuff. > > - Dave > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
