Felipe Balbi <felipe.balbi@xxxxxxxxx> writes: > On Tue, Nov 18, 2008 at 03:00:37PM +0200, Jouni Högander wrote: >> Currently mcspi wake-ups are not enabled. This might cause case where >> OMAP is not waking up on mcspi events. >> >> Signed-off-by: Jouni Hogander <jouni.hogander@xxxxxxxxx> >> --- >> drivers/spi/omap2_mcspi.c | 11 +++++++++-- >> 1 files changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c >> index 454a271..4bd330c 100644 >> --- a/drivers/spi/omap2_mcspi.c >> +++ b/drivers/spi/omap2_mcspi.c >> @@ -59,6 +59,8 @@ >> >> /* per-register bitmasks: */ >> >> +#define OMAP2_MCSPI_SYSCONFIG_SMARTIDLE (0x2 << 3) >> +#define OMAP2_MCSPI_SYSCONFIG_ENAWAKEUP (0x1 << 2) > > could you follow the convention below and use (1 << offset) ?? There aren't any convention in this driver, but I can change my patch. -- Jouni Högander -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
