Re: [patch/rft 2.6.28-rc3-omap] twl4030-core simplification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* David Brownell <david-b@xxxxxxxxxxx> [081113 17:05]:
> On Thursday 13 November 2008, Tony Lindgren wrote:
> > If CONFIG_REGULATOR is not set, I get:
> > 
> > drivers/mfd/twl4030-core.c: In function 'add_children':
> > drivers/mfd/twl4030-core.c:592: error: 'REGULATOR_MODE_OFF' undeclared (first use in this function)
> > 
> > Where do you want to have that for now? Add it also into
> > twl4030-core.c like in twl4030-regulator.c?
> 
> #ifndef REGULATOR_MODE_OFF
> #define REGULATOR_MODE_OFF 0
> #endif
> 
> for now... but the fact that you're getting that at all seems to
> mean you're applying the third regulator patch (register regulators)
> without the fourth (debug oriented) which has that #ifndef.
> 
> Don't merge regulator patches #3 or #4 yet ... #2 should be OK,
> but it's a NOP without #3 (which has the is ifdef issue).

OK, thanks. Pushed the first two only.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux