RE: [PATCH OMAPZOOM] OMAP: DMA: Fix CCR programming for request line > 63

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pushed to zoom tree.

>-----Original Message-----
>From: Gadiyar, Anand
>Sent: Monday, November 10, 2008 5:08 AM
>To: linux-omap@xxxxxxxxxxxxxxx
>Cc: Pandita, Vikram; tony@xxxxxxxxxxx
>Subject: [PATCH OMAPZOOM] OMAP: DMA: Fix CCR programming for request line > 63
>
>From: Anand Gadiyar <gadiyar@xxxxxx>
>
>Bug in existing code causes synchro control to be set +32 if request
>line greater than 63 is used.
>
>Reported by Wenbiao Wang
>
>Signed-off-by: Anand Gadiyar <gadiyar@xxxxxx>
>---
>Patch generated against OMAPZOOM tree. Will apply against
>linux-omap as well with an offset of 8 lines.
>
>diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
>index 562089e..b38a362 100644
>--- a/arch/arm/plat-omap/dma.c
>+++ b/arch/arm/plat-omap/dma.c
>@@ -287,10 +287,7 @@ void omap_set_dma_transfer_params(int lch, int data_type, int elem_count,
>
> 		val = dma_read(CCR(lch));
> 		val &= ~(3 << 19);
>-		if (dma_trigger > 63)
>-			val |= 1 << 20;
>-		if (dma_trigger > 31)
>-			val |= 1 << 19;
>+		val |= ((dma_trigger & ~(0x1f)) << 14);
>
> 		val &= ~(0x1f);
> 		val |= (dma_trigger & 0x1f);
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux