On Wednesday 05 November 2008, Stanley.Miao wrote: > @@ -333,7 +333,8 @@ struct omap_mcbsp_platform_data { > u8 dma_rx_sync, dma_tx_sync; > u16 rx_irq, tx_irq; > struct omap_mcbsp_ops *ops; > - char const *clk_name; > + char const *ick_name; > + char const *fck_name; > }; > > struct omap_mcbsp { I thought the idea was to fix this using the clock aliasing facility ... so that the mcbsp driver would just ick = clk_get(dev, "ick"); fck = clk_get(dev, "fck"); (with IS_ERR checks of course) and the platform data would no longer need to hold those names. That approach can work on OMAP1 too ... I think this patch breaks OMAP1 boards. - Dave -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html