On Thu, Nov 6, 2008 at 12:39 AM, Felipe Balbi <me@xxxxxxxxxxxxxxx> wrote: > On Wed, Nov 05, 2008 at 11:19:42PM +0200, Grazvydas Ignotas wrote: >> + >> +#ifndef __ASM_ARCH_OMAP3_PANDORA_H >> +#define __ASM_ARCH_OMAP3_PANDORA_H >> + >> +#define OMAP3_PANDORA_TS_GPIO 94 > > for one define only ??? > > Do you have plans to add more stuff here ? Do you have any other files > that might need this define besides the main board-file ?? > > Looks unnecessary to add yet another header for one define only. Moving > to the board-file would be more acceptable. Yes, it's more like a placeholder for future patches. I plan to add a function prototype and some more GPIOs. I also plan adding another board file for input stuff (board-omap3pandora-input.c), as pandora has lots of GPIO buttons with full qwerty keypad, and I don't want to clutter the main board file with large arrays of structures. If this is not acceptable I can stuff everything into board-omap3pandora.c -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
