Re: [PATCH] OMAP2 NAND: Fix __raw_readsl() length argument

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 22, 2008 at 2:46 PM, David Brownell <david-b@xxxxxxxxxxx> wrote:
> On Wednesday 22 October 2008, Juha Kuikka wrote:
>> -       __raw_readsl(nand->IO_ADDR_R, buf, len / 2);
>> +       __raw_readsl(nand->IO_ADDR_R, buf, len / 4);
>>  }
>
> Shouldn't that have been __raw_readsw() though?
>
Hmh, good point.

>From the original code it looks like that was the intention but
readsl() works just as well.

I tested this on OMAP2430 and it works ok.

I don't see any mentions in the TRM about the width of the
GPMC_NAND_DATA registers but apparently the NAND engine happily
accepts 32bit accesses on bus.


 - Juha


-- 
Madness takes it's toll. Please have exact change.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux