Re: PATCH 2/2 OMAP: HSMMC: Disable the mmc clocks when not needed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 21, 2008 at 03:46:24PM +0300, Jarkko Lavinen wrote:
+static void omap_mmc_clks_disable(struct mmc_omap_host *host)
+{
+       unsigned long flags;
+
+       spin_lock_irqsave(&host->clk_lock, flags);
....
+       host->clks_enabled = 0;
+
+       return;
+}

Talking to myself here, but you just forgot spin_unlock_irqrestore()
from above.

Also I think one should enable the clocks in omap_mmc_set_ios() before 
touching the MMC controller registers.  And shut down the clocks when 
powering down.

Cheers
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux